-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6847 Create anonymous_or_unrevealed_notification mailer preview #5040
Merged
brianjaustin
merged 5 commits into
otwcode:master
from
amecreate:AO3-6847_anonymous_or_unrevealed_notification_mailer_preview
Feb 18, 2025
Merged
AO3-6847 Create anonymous_or_unrevealed_notification mailer preview #5040
brianjaustin
merged 5 commits into
otwcode:master
from
amecreate:AO3-6847_anonymous_or_unrevealed_notification_mailer_preview
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
requested changes
Jan 31, 2025
Bilka2
reviewed
Feb 10, 2025
brianjaustin
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6847
Purpose
Add mailer preview for the
anonymous_or_unrevealed_notification
email.Include cucumber test for sending a translated
anonymous_or_unrevealed_notification
email to a user.Remove the redundant
html_safe
call in the HTML mail.Testing Instructions
See Jira.
References
Credit
Amy Lee